[PARAMETER] Print bool value as 0/1 to make parsing easier (apache#314)

* [PARAMETER] Print bool value as 0/1 to make parsing easier * add defult value to type name
eric-haibin-lin · Sep 25, 2017 · 04f9195 · 04f9195
1 parent b09d2b7
commit 04f9195
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/include/dmlc/parameter.h b/include/dmlc/parameter.h
@@ -963,11 +963,7 @@ class FieldEntry<bool>
  protected:
   // print default string
   virtual void PrintValue(std::ostream &os, bool value) const {  // NOLINT(*)
-    if (value) {
-      os << "True";
-    } else {
-      os << "False";
-    }
+    os << static_cast<int>(value);
   }
 };
 

diff --git a/include/dmlc/type_traits.h b/include/dmlc/type_traits.h
@@ -77,7 +77,7 @@ struct is_arithmetic {
 
 /*!
  * \brief helper class to construct a string that represents type name
- * 
+ *
  * Specialized this class to defined type name of custom types
  *
  * \tparam T the type to query
@@ -87,7 +87,9 @@ struct type_name_helper {
   /*!
    * \return a string of typename.
    */
-  static inline std::string value();
+  static inline std::string value() {
+    return "";
+  }
 };
 
 /*!