Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption of hdwallet #83

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Encryption of hdwallet #83

merged 2 commits into from
Jun 30, 2023

Conversation

eric-volz
Copy link
Owner

Ability to encrypt a created wallet with a passphrase into a string. This encryption can also be stored in a file.
For the next use the string can be decrypted with the passphrase. The implementation automatically interprets the decrypted string as a wallet object.


def __init__(self, key):
self._bs = AES.block_size
self._key = hashlib.sha256(key.encode()).digest()

Check failure

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data

[Sensitive data (password)](1) is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function. [Sensitive data (password)](2) is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function. [Sensitive data (password)](3) is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function. [Sensitive data (password)](4) is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function. [Sensitive data (password)](5) is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function. [Sensitive data (password)](6) is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is not meant to be a long term storage solution. It should just add another protection layer.

@eric-volz eric-volz merged commit 451c0c4 into main Jun 30, 2023
@eric-volz eric-volz deleted the hdwallet/encryption branch June 30, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant