-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Remix/ESBuild support by checking the _debugOwner._debugSource #73
Conversation
🦋 Changeset detectedLatest commit: d62564c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Will remix support be accepted? PR is already half a year old, are there any problems with this? Also in the latest remix version (2.1.0) I get: /node_modules/cliui/build/index.cjs:291
const stringWidth = require('string-width');
^
Error [ERR_REQUIRE_ESM]: require() of ES Module /node_modules/string-width/index.js from /node_modules/cliui/build/index.cjs not supported.
Instead change the require of index.js in /node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules. |
oops, I added |
As Remix/ESBuild
_debugSource
filepaths are relative I had to also add GaitanK's code in order to make path absolute in my Remix app.ESBuild has added _debugSource for a long time now evanw/esbuild#2318 but looks like at least in React 18 we need to read it from somewhere else.
@ericclemmons, happy to have your feedback on this.