Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin to work with Grunt 0.4.0 #5

Closed
jgrund opened this issue Jan 25, 2013 · 6 comments
Closed

Update plugin to work with Grunt 0.4.0 #5

jgrund opened this issue Jan 25, 2013 · 6 comments
Assignees
@ericclemmons

Comments

@jgrund
Copy link
Contributor

jgrund commented Jan 25, 2013

Consider making a separate branch and update the plugin to work with grunt 0.4.0.

This could be done on a separate branch.

Right now when running the task in grunt 0.4.0rc7, I get the following error:

Warning: Object #<Object> has no method 'expandDirs' Use --force to continue.
@ghost ghost assigned ericclemmons Jan 25, 2013
@ericclemmons
Copy link
Owner

Will do!

jgrund added a commit to jgrund/grunt-angular-templates that referenced this issue Jan 25, 2013
@jgrund
ericclemmons#5
7686a16 
- Got plugin working with grunt 0.4.0.
@ericclemmons
Copy link
Owner

@jgrund Nice commit! Can you issue a PR, or would you prefer that I just git cherry-pick it?

@jgrund
Copy link
Contributor Author

jgrund commented Jan 28, 2013

@ericclemmons Yes, I will issue a PR shortly.

@jgrund
Copy link
Contributor Author

jgrund commented Jan 28, 2013

Actually, could you create a new branch to merge into so I don't merge the 0.4 changes into master?

@ericclemmons
Copy link
Owner

Isn't it OK to merge 0.4 changes into master? I thought 0.4 and 0.3.x should work together, or at least several of the grunt-contrib-* do...

On Monday, January 28, 2013 at 9:13 AM, Joe Grund wrote:

Actually, could you create a new branch to merge into so I don't merge the 0.4 changes into master?

—
Reply to this email directly or view it on GitHub (#5 (comment)).

@jgrund
Copy link
Contributor Author

jgrund commented Jan 28, 2013

There are a number of breaking changes between 0.3 and 0.4. Check out this Upgrade Guide for more info.

ericclemmons pushed a commit that referenced this issue Jan 28, 2013
@jgrund @ericclemmons
#5
3c76497 
- Got plugin working with grunt 0.4.0.
@ericclemmons ericclemmons mentioned this issue Jan 28, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericclemmons ericclemmons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericclemmons @jgrund