Use '\n' to join the template cache entries regardless of platform #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also leaves the template cache contents untouched, rather than using normalizelf(). This will ensure that developers using the same repo on different OSes will have identical grunt build output, avoiding constant churn when the built files are committed to the repository. I've used '\n' for the joins since the rest of grunt-angular-templates uses it, as do other grunt plugins like grunt-contrib-uglify and grunt-usemin. Fixes #125.
|
@ericclemmons, let me know if I need to do anything else before this can be merged :-) |
|
Going to merge this, but probably bump versions because people have varying opinions on the "right" linefeed ending =/ |
|
Ok, thank you :-) |
|
@ericclemmons any news on this? :-) |
|
Would you be interested in #137? I need help... |
Unfortunately I don't think I have the grunt expertise to help out at the moment. My team has also changed its deployment strategy, so we no longer run into this issue (the grunt build is performed on deploy instead of being committed to the repo). If someone wants to take over the PR, they are most welcome :-) |
|
Created #154 as an alternative to this, going to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also leaves the template cache contents untouched, rather than using normalizelf().
This will ensure that developers using the same repo on different OSes will have identical grunt build output, avoiding constant churn when the built files are committed to the repository.
I've used '\n' for the joins since the rest of grunt-angular-templates uses it, as do other grunt plugins like grunt-contrib-uglify and grunt-usemin.
Fixes #125.
@ericclemmons, could you take a look? :-)