Skip to content

Commit

Permalink
Merge pull request #8 from ericdbarry/bugfix/#37_posting_url_not_correct
Browse files Browse the repository at this point in the history
awslabs#37 Fixing incorrect endpoint for posting the form data.
  • Loading branch information
ericdbarry authored Jul 30, 2019
2 parents a11feb1 + 384a5ac commit 3cc3756
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion awsprocesscreds/saml.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def _retrieve_login_form_from_endpoint(self, endpoint):
login_form_html_node = self._parse_form_from_html(response.text)
if login_form_html_node is None:
raise SAMLError(self._ERROR_NO_FORM % endpoint)
form_action = urljoin(endpoint,
form_action = urljoin(response.url,
login_form_html_node.attrib.get('action', ''))
if not form_action.lower().startswith('https://'):
raise SAMLError('Your SAML IdP must use HTTPS connection')
Expand Down

0 comments on commit 3cc3756

Please sign in to comment.