Skip to content

fix: 0 length never matching #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: 0 length never matching #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1df97
test: Add test for literal 0
eps1lon Nov 12, 2019
5094cd1
fix: 0 length never matching
eps1lon Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function matchQuery(mediaQuery, values) {
value = values[feature];

// Missing or falsy values don't match.
if (!value) { return false; }
if (!value && value !== 0) { return false; }

switch (feature) {
case 'orientation':
Expand Down
6 changes: 6 additions & 0 deletions test/unit-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ describe('mediaQuery.match()', function () {
'(max-height: 1000px)', {height: '60pc'}
)).to.be.true;
});

it('should work with literal 0', function () {
expect(mediaQuery.match(
'(max-height: 1000px)', {height: 0}
)).to.be.true;
});
});

});
Expand Down