Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore list to match method #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shamenchens
Copy link

No description provided.

@ericf
Copy link
Owner

ericf commented Apr 18, 2014

Can you please provide the rationale for this?

@shamenchens
Copy link
Author

It could be useful when you want some values to check against, and some of them you don't really care at all, and those values could put in the ignore list to prevent checking on them.
For example, the min-width is the thing to be take care of but the orientation is not really important. We can specify the criteria on min-width and put orientation in the ignore list, so it can provide matches on min-width and regardless the orientation is landscape, portrait, or even not specified.

@ericf
Copy link
Owner

ericf commented Apr 21, 2014

I'm hesitant to add this because it doesn't match how a browser would try to match its current state against a CSS Media Query. I feel that adding another param for ignore list is not the way to go. I could possibly see using {orientation: 'any'} and supporting that, but this feels like a slippery slope.

What's an actual example of where this would be necessary? Because it seems like you could easily tweak your CSS to get the desired result.

Also is orientation the only Media Feature you use where you've run into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants