Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent labels #26

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Consistent labels #26

merged 5 commits into from
Jan 26, 2024

Conversation

ericfell
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ccb5a06) 92.92% compared to head (f6d2b4a) 92.46%.

Files Patch % Lines
src/rfbzero/redox_flow_cell.py 95.23% 2 Missing ⚠️
src/rfbzero/crossover.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   92.92%   92.46%   -0.46%     
==========================================
  Files           4        4              
  Lines         565      571       +6     
==========================================
+ Hits          525      528       +3     
- Misses         40       43       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jeremyfell jeremyfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, got a few minor comments

src/rfbzero/crossover.py Outdated Show resolved Hide resolved
src/rfbzero/experiment.py Outdated Show resolved Hide resolved
src/rfbzero/experiment.py Outdated Show resolved Hide resolved
src/rfbzero/experiment.py Outdated Show resolved Hide resolved
src/rfbzero/experiment.py Outdated Show resolved Hide resolved
src/rfbzero/redox_flow_cell.py Outdated Show resolved Hide resolved
src/rfbzero/redox_flow_cell.py Outdated Show resolved Hide resolved
src/rfbzero/redox_flow_cell.py Outdated Show resolved Hide resolved
src/rfbzero/redox_flow_cell.py Outdated Show resolved Hide resolved
src/rfbzero/experiment.py Outdated Show resolved Hide resolved
@ericfell ericfell merged commit 591e40d into main Jan 26, 2024
3 of 4 checks passed
@jeremyfell jeremyfell deleted the consistent-labels branch January 31, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants