Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extra product species in degradation mechanisms #29

Merged
merged 13 commits into from
Jan 30, 2024
Merged

Support extra product species in degradation mechanisms #29

merged 13 commits into from
Jan 30, 2024

Conversation

jeremyfell
Copy link
Collaborator

No description provided.

ericfell
ericfell reviewed Jan 29, 2024
View reviewed changes
tests/test_experiment.py Outdated Show resolved Hide resolved
ericfell
ericfell reviewed Jan 29, 2024
View reviewed changes
src/rfbzero/experiment.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9b8c957) 92.46% compared to head (8b9c5ac) 94.52%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/rfbzero/experiment.py 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   92.46%   94.52%   +2.05%     
==========================================
  Files           4        4              
  Lines         571      603      +32     
==========================================
+ Hits          528      570      +42     
+ Misses         43       33      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericfell ericfell marked this pull request as ready for review January 30, 2024 14:49
jeremyfell
jeremyfell commented Jan 30, 2024
View reviewed changes
Copy link
Collaborator Author

@jeremyfell jeremyfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look good to me

ericfell
ericfell approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@ericfell ericfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericfell ericfell merged commit 9e850de into main Jan 30, 2024
4 checks passed
@jeremyfell jeremyfell deleted the product-species branch January 31, 2024 01:45
@jeremyfell jeremyfell restored the product-species branch January 31, 2024 01:45
@jeremyfell jeremyfell deleted the product-species branch January 31, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfell ericfell ericfell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyfell @ericfell