Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 35 joss #40

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Issue 35 joss #40

merged 4 commits into from
Jun 5, 2024

Conversation

ericfell
Copy link
Owner

@ericfell ericfell commented Jun 4, 2024

Improve community guidelines, contributions sections, regarding #35

Add installation section to the documentation notebook, regarding #37

Related to openjournals/joss-reviews#6537

@ericfell ericfell requested a review from jeremyfell June 4, 2024 19:02
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (ea4ee76) to head (9105cc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files           4        4           
  Lines         608      608           
=======================================
  Hits          577      577           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jeremyfell jeremyfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM overall

docs/source/faq.rst Outdated Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ericfell ericfell merged commit f6852fe into main Jun 5, 2024
4 checks passed
@ericfell ericfell deleted the issue-35-joss branch June 12, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants