Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint appears even when there are no results #203

Closed
ericgio opened this issue Jun 23, 2017 · 2 comments
Closed

Hint appears even when there are no results #203

ericgio opened this issue Jun 23, 2017 · 2 comments
Labels
bug
Milestone
v2.0.0

Comments

@ericgio
Copy link
Owner

ericgio commented Jun 23, 2017

Version

1.4.0

Steps to reproduce

  • Go to examples
  • In "Filtering" example, check "Don't ignore diacritical marks"
  • Type "gdan"

Expected Behavior

No hint should be shown

Actual Behavior

Hint/autocomplete is shown for Gdansk, even though the menu says there are no results
@ericgio ericgio added the bug label Jun 23, 2017
@ericgio
Copy link
Owner Author

ericgio commented Jul 3, 2017

Root cause seems to be that this.state.initialItem is not updated when the result set is empty.

ericgio added a commit that referenced this issue Jul 15, 2017
@ericgio
Set initialItem to null when there are no results (#203)
df1d44d
@ericgio ericgio added this to the 2.0 milestone Jul 20, 2017
@ericgio
Copy link
Owner Author

ericgio commented Jul 21, 2017

Fixed in v2.0.0-alpha.1

@ericgio ericgio closed this as completed Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@ericgio