react-overlays 0.8.3 removes getOverlayDOMNode, breaks bodyContainer

[bdjnk]

Version

2.0

Steps to reproduce

1. npm install
2. react-overlays will install 0.8.3
3. Use the bodyContainer prop

Expected Behavior

Dropdown positioned correctly without errors.

Actual Behavior

Dropdown incorrectly positioned. Error Uncaught TypeError: n._portal.getOverlayDOMNode is not a function printed to console.

---

This behavior is due to a merged pull request to react-overlays, Drop busted getOverlayDOMNode.

Meanwhile, react-bootstrap-typeahead expects getOverlayDOMNode in Overlay.react.js, line 110.

[ericgio]

ugh, thanks

[ericgio]

Just released v2.0.0-rc.1, which should fix this issue.

[seidelman]

@ericgio Seems like published NPM for v2.0.0-rc.1 contains dist and lib files from October 26

 curl https://registry.npmjs.org/react-bootstrap-typeahead/-/react-bootstrap-typeahead-2.0.0-rc.1.tgz | tar tv
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0-rw-r--r--  0 501    20       2625 Oct 30 14:51 package/package.json
-rw-r--r--  0 501    20       2852 Oct 26 16:26 package/README.md
-rw-r--r--  0 501    20     377940 Oct 26 16:37 package/dist/react-bootstrap-typeahead.js
100  144k  100  144k    0     0  3640k      0 --:--:-- --:--:-- --:--:-strap-typeahead.min.js
- 3696k
-rw-r--r--  0 501    20        195 Jun 12 01:54 package/CHANGELOG.md
-rw-r--r--  0 501    20       1091 Jun 12 01:54 package/LICENSE.md
-rw-r--r--  0 501    20       3094 Oct 30 14:47 package/css/Typeahead.css
-rw-r--r--  0 501    20        219 Oct 26 16:26 package/docs/README.md
-rw-r--r--  0 501    20       4642 Oct 26 16:26 package/docs/API.md
-rw-r--r--  0 501    20       1741 Jun 12 01:54 package/docs/Data.md
-rw-r--r--  0 501    20       1707 Jun 12 01:54 package/docs/Filtering.md
-rw-r--r--  0 501    20       1396 Jun 12 01:54 package/docs/Methods.md
-rw-r--r--  0 501    20       5692 Oct 26 16:26 package/docs/Props.md
-rw-r--r--  0 501    20       3425 Jun 12 01:54 package/docs/Rendering.md
-rw-r--r--  0 501    20       2297 Oct 28 15:08 package/docs/Upgrading.md
-rw-r--r--  0 501    20       1137 Jun 12 01:54 package/docs/Usage.md
-rw-r--r--  0 501    20        478 Oct 26 16:37 package/lib/AsyncTypeahead.react.js
-rw-r--r--  0 501    20        880 Oct 26 16:37 package/lib/Loader.react.js
-rw-r--r--  0 501    20       5809 Oct 26 16:37 package/lib/Menu.react.js
-rw-r--r--  0 501    20       3939 Oct 26 16:37 package/lib/MenuItem.react.js
-rw-r--r--  0 501    20       5141 Oct 26 16:37 package/lib/HintedInput.react.js
-rw-r--r--  0 501    20       5833 Oct 26 16:37 package/lib/Token.react.js
-rw-r--r--  0 501    20       2121 Oct 26 16:37 package/lib/ClearButton.react.js
-rw-r--r--  0 501    20       5610 Oct 26 16:37 package/lib/TypeaheadInput.react.js
-rw-r--r--  0 501    20       5653 Oct 26 16:37 package/lib/TypeaheadMenu.react.js
-rw-r--r--  0 501    20       1732 Oct 26 16:37 package/lib/index.js
-rw-r--r--  0 501    20       7859 Oct 26 16:37 package/lib/Overlay.react.js
-rw-r--r--  0 501    20       9790 Oct 26 16:37 package/lib/Typeahead.react.js
-rw-r--r--  0 501    20       9060 Oct 26 16:37 package/lib/containers/asyncContainer.js
-rw-r--r--  0 501    20       5995 Oct 26 16:37 package/lib/containers/menuItemContainer.js
-rw-r--r--  0 501    20       5164 Oct 26 16:37 package/lib/containers/tokenContainer.js
-rw-r--r--  0 501    20      23483 Oct 26 16:37 package/lib/containers/typeaheadContainer.js
-rw-r--r--  0 501    20       8057 Oct 26 16:37 package/lib/containers/typeaheadInputContainer.js
-rw-r--r--  0 501    20        338 Oct 26 16:37 package/lib/constants/keyCode.js
-rw-r--r--  0 501    20        579 Oct 26 16:37 package/lib/propTypes/caseSensitiveType.js
-rw-r--r--  0 501    20        895 Oct 26 16:37 package/lib/propTypes/checkPropType.js
-rw-r--r--  0 501    20        577 Oct 26 16:37 package/lib/propTypes/highlightOnlyResultType.js
-rw-r--r--  0 501    20        596 Oct 26 16:37 package/lib/propTypes/ignoreDiacriticsType.js
-rw-r--r--  0 501    20       1547 Oct 26 16:37 package/lib/propTypes/index.js
-rw-r--r--  0 501    20       1101 Oct 26 16:37 package/lib/propTypes/inputPropsType.js
-rw-r--r--  0 501    20        543 Oct 26 16:37 package/lib/propTypes/labelKeyType.js
-rw-r--r--  0 501    20       1579 Oct 26 16:37 package/lib/utils/addCustomOption.js
-rw-r--r--  0 501    20        238 Oct 26 16:37 package/lib/utils/getDisplayName.js
-rw-r--r--  0 501    20       1737 Oct 26 16:37 package/lib/utils/getHintText.js
-rw-r--r--  0 501    20        908 Oct 26 16:37 package/lib/utils/getInputText.js
-rw-r--r--  0 501    20        628 Oct 26 16:37 package/lib/utils/getAccessibilityStatus.js
-rw-r--r--  0 501    20        373 Oct 26 16:37 package/lib/utils/getTruncatedOptions.js
-rw-r--r--  0 501    20       2640 Oct 26 16:37 package/lib/utils/index.js
-rw-r--r--  0 501    20        377 Oct 26 16:37 package/lib/utils/pluralize.js
-rw-r--r--  0 501    20       1015 Oct 26 16:37 package/lib/utils/scrollIntoViewIfNeeded.js
-rw-r--r--  0 501    20       8915 Oct 26 16:37 package/lib/utils/stripDiacritics.js
-rw-r--r--  0 501    20       2252 Oct 26 16:37 package/lib/utils/defaultFilterBy.js
-rw-r--r--  0 501    20       1031 Oct 26 16:37 package/lib/utils/warn.js
-rw-r--r--  0 501    20       1446 Oct 26 16:37 package/lib/utils/getOptionLabel.js```

[ericgio]

@seidelman: That's really odd. Looks like you're right though as far as I can tell, the build and publish process went as expected. I have no idea why stale files were included.

[ericgio]

v2.0.0-rc.2 is now up and looks like it has the correct files.