Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bodyContainer prop replaces body class instead of adding to class list #273

Closed
pinksynth opened this issue Nov 27, 2017 · 3 comments
Closed

bodyContainer prop replaces body class instead of adding to class list #273

pinksynth opened this issue Nov 27, 2017 · 3 comments

Comments

@pinksynth
Copy link

When the bodyContainer prop is set to true, opening the typeahead input replaces the <body> element's class attribute with rbt-body-container. Instead, should it not append that class to <body>'s class list?

First time question-asker here, thanks for your time.

Info

Version

2.0.0 / latest

Steps to reproduce

Set bodyContainer prop to true, open typeahead input.

Expected Behavior

<body> element's class list gets appended with rbt-body-container.

Actual Behavior

<body> element's class list gets replaced by rbt-body-container.
@ericgio
Copy link
Owner

ericgio commented Nov 27, 2017

Yeah, that sounds right. Thanks for the report.

ericgio added a commit that referenced this issue Nov 28, 2017
@ericgio
Add/remove body container className instead of replacing (#273)
101b5d9
@ericgio
Copy link
Owner

ericgio commented Nov 28, 2017

Fixed in v2.0.1

@ericgio ericgio closed this as completed Nov 28, 2017
@pinksynth
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericgio @pinksynth