Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreDiacritics does not remove combining diacritics #279

Closed
greendemiurge opened this issue Dec 19, 2017 · 3 comments
Closed

ignoreDiacritics does not remove combining diacritics #279

greendemiurge opened this issue Dec 19, 2017 · 3 comments

Comments

@greendemiurge
Copy link

greendemiurge commented Dec 19, 2017

Version

1.4.2

Steps to reproduce

  • Set an array of options with items that have both combining and composed diacritics:
var options = [
  {id: 1, name: 'Für with composed diacritic'},
  {id: 2, name: 'Für with combining diacritic'},
];
  • Search using fur

Expected Behavior

Both options should return

Actual Behavior

Only the option with the composed diacritic with return (option id 1).

N.B.
https://en.wikipedia.org/wiki/Combining_Diacritical_Marks

@ericgio
Copy link
Owner

ericgio commented Jan 8, 2018

For posterity, here's the repro case:

const options = [
  'Für with composed diacritic.',
  'Fu\u0308r with combined diacritic.',
];

@ericgio
Copy link
Owner

ericgio commented Jan 14, 2018

This should now be fixed in v2.1.0. Thanks for raising this issue, by the way. It was challenging to solve, but I learned a lot in the process!

@ericgio ericgio closed this as completed Jan 14, 2018
@greendemiurge
Copy link
Author

Thank you so much for resolving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants