-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relaxing emptyLabel's PropType requirements #292
Comments
No good reason other than a string seemed like the most likely use case and I hadn't encountered a need for more. I don't see why a component shouldn't be allowed. |
For clarification, passing a component to |
Should probably just be
|
This should be resolved as of v2.3.0 |
It appears that giving
emptyLabel
a React component renders that component just fine. I didn't look too far into the reasoning behind whyemptyLabel
is required to be a string, but I believe React components should be allowed as well. Is there another way to giveemptyLabel
React components that I am missing, or a reason why React components are not accepted?For convenience, the line with the PropType.
react-bootstrap-typeahead/src/containers/typeaheadContainer.js
Line 410 in 60ea7ce
The text was updated successfully, but these errors were encountered: