-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popper: CSS "margin" styles cannot be used to apply padding ... #713
Comments
Hey @jakajancar thanks for opening this issue. Full details outlined in #549, but this is a side-effect of upgrading react-popper/PopperJs. Bootstrap 5 also relies on PopperJs v2, and does away with the offending margin styles that triggered the warning. Unfortunately, there are one or two styles still included in this library that may be triggering the warning as well. The styles are there for backwards compatibility with BS4, which I still want to support for at least the next major version (v6) or so. Please note that this is just a warning and not an error. |
Got it, thanks. Perhaps just the Upgrade guide should be updated to say the warnings are expected also with Bootstrap 5 (right now it says only with < 5). |
I just override the margin property for all child elements. css file
js file(react)
|
Thanks @devashtar |
@devashtar Thanks, worked for me too though I had to use |
Version
6.0.0-alpha.11
Steps to reproduce
Even the default CodeSandbox demo reproduces it after updating the version.
Expected Behavior
The Upgrade guide says:
Actual Behavior
The error happens also with Bootstrap 5.
The text was updated successfully, but these errors were encountered: