Skip to content

Commit

Permalink
feat(update_expected)!: recommend disabled on entirely SKIPped tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ErichDonGubler committed May 7, 2024
1 parent 011cd12 commit 1fd4a22
Showing 1 changed file with 21 additions and 1 deletion.
22 changes: 21 additions & 1 deletion moz-webgpu-cts/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,27 @@ fn run(cli: Cli) -> ExitCode {
// Do this so that test runs whose coverage _in aggregate_ includes actual
// runs on this test are viable for processing. Otherwise, we'd have `SKIP`
// outcomes be included that aren't actually wanted.
if *reported != skip {
if *reported == skip {
if properties.is_disabled {
// Let this outcome be processed as others.
} else {
log::warn!(
concat!(
"`{}` was the only outcome found ",
"in the set of reported test outcomes(s) ",
"for {:?} with platform {:?} and build profile {:?}, ",
"which means it wasn't run; ",
"consider marking the individual test as ",
"`disabled` ",
" to silence this warning",
),
skip,
test_path,
platform,
build_profile,
)
}
} else {
let skip = skip.into();
if reported.inner().is_superset(skip) {
log::debug!(
Expand Down

0 comments on commit 1fd4a22

Please sign in to comment.