PollItem: Support checking associated socket #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotty
reviewed
Dec 15, 2019
fwalch
force-pushed
the
pollitem-identification
branch
from
bcd9d0c to
075825d
Compare
|
Thanks for the comment, fixed the issue and added an assertion to the tests. I'm not completely happy with the function names, as they are very similar to the revents checks (e.g. |
|
Thanks for updating! I agree naming these |
Adds has_socket and has_fd to PollItem to allow checking which socket a PollItem has been created from. Enables some use cases related to erickt#68.
fwalch
force-pushed
the
pollitem-identification
branch
from
075825d to
e9f795f
Compare
Renamed the functions. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds is_socket and is_fd to PollItem to allow checking which socket a
PollItem has been created from.
Enables some use cases related to #68.