Remove std::error::Error description method implementations
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `description` method has been soft-deprecated for some time now,
and current nightly (1.41) warns upon its use:
warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
Since our `description` implementation made use of the underlying
error's `description` method, we triggered that warning. Let's fix
that by just getting rid of the implementation containing the
offending code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
descriptionmethod has been soft-deprecated for some time now,and current nightly (1.41) warns upon its use:
Since our
descriptionimplementation made use of the underlyingerror's
descriptionmethod, we triggered that warning. Let's fixthat by just getting rid of the implementation containing the
offending code.