Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session creation race conditions #75

Closed
ericmann opened this issue Jan 1, 2019 · 0 comments
Closed

Session creation race conditions #75

ericmann opened this issue Jan 1, 2019 · 0 comments
Labels
Milestone

Comments

@ericmann
Copy link
Owner

ericmann commented Jan 1, 2019

Reported in the WordPress forums => https://wordpress.org/support/topic/php-7-2-warning-5/

If another plugin or the theme sets up the session before we hook in, PHP 7.2 will trigger a warning pointing out that we've tried to reset the save handler after a session is already active. We need to hook in as early as possible and trigger our own error if something has interfered with the system's normal path of operation.

@ericmann ericmann added the bug label Jan 1, 2019
@ericmann ericmann added this to the 4.1.0 milestone Jan 1, 2019
ericmann added a commit that referenced this issue Jan 3, 2019
@ericmann ericmann mentioned this issue Jan 3, 2019
ericmann added a commit that referenced this issue Jan 7, 2019
* Add some defense to ensure end users are running the correct version of PHP before loading the system. (#76)
* Eliminate a race condition where another plugin or the theme created the session first. (#75)
* Schedule a cron to auto-delete expired sessions. (#77)

Closes #75, closes #76, closes #77, resolves #78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant