Release connection if client query returns an error #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, after checking out a connection from pool and running a query that errors (either due to a bug or e.g. clickhouse being inaccessible) the connection is never reset. This can lead to bugs down the line.
macobo
added a commit
to PostHog/posthog
that referenced
this pull request
Jun 11, 2021
Fixed a bug upstream, waiting for it to get released. ericmccarthy7/clickhouse-pool#12
6 tasks
macobo
added a commit
to PostHog/posthog
that referenced
this pull request
Jun 11, 2021
Fixed a bug upstream, waiting for it to get released. ericmccarthy7/clickhouse-pool#12
|
Thanks so much for the PR. Great catch! I will spend some time later today to ensure it gets published on pypi. |
|
This has been merged and is in the current pypi version. |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after checking out a connection from pool and running a query
that errors (either due to a bug or e.g. clickhouse being inaccessible)
the connection is never reset. This can lead to the connection pool being filled with inaccessible connections.
Took a quick stab at fixing this - @ericmccarthy7 mind taking a look?