Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 support #3

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Add PHP 8.1 support #3

merged 2 commits into from
Dec 5, 2022

Conversation

paxal
Copy link
Contributor

@paxal paxal commented Feb 23, 2022

Hi 👋

I'm trying to update my project to PHP 8.1 but it's not compatible due to php_user_filter signature changes in typed properties.

Moreover, there is a modification in PHP 8.1 regarding SJIS I don't know how to address, so I removed the relevant chars from the tests.

Mainly because of 1), this version is only PHP 8.1 compatible (not compatible with PHP 7 nor 8.0)

@ericnorris
Copy link
Owner

Hey @paxal, thanks for your interest! I'll try to take an in-depth look this weekend.

For what it's worth, I think that due to #1 it's preferable to instead contribute an mbstring equivalent of convert.iconv.* to https://github.com/php/php-src, rather than using this library. I've never been motivated enough to pursue this, however.

@ericnorris
Copy link
Owner

Hello again @paxal - I've renamed the default branch to main and switched to GitHub Actions instead of Travis CI; do you mind rebasing your change and making the necessary update to the CI workflow?

@ericnorris
Copy link
Owner

Thanks! I've approved the GitHub actions run, looks like there's a phpunit version upgrade change you'll need to make, since I had to pin to an earlier version for the previous PHP 7 build.

@paxal
Copy link
Contributor Author

paxal commented Mar 7, 2022

@ericnorris updated ! But still I'l check about convert.iconv.* filters :)

@Karpec
Copy link

Karpec commented Nov 30, 2022

Hi @ericnorris,
can you release new version with this fix? That would be great!

@ericnorris ericnorris merged commit 2758e00 into ericnorris:main Dec 5, 2022
@ericnorris
Copy link
Owner

@Karpec done! @paxal thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants