The code has been simplified by replacing the use of
UCIContain.listOptions with checks to see if (UCIContainer.value
instanceof Array). Also bugs identified and fixed.

Background. While implementing new functionality to store uci list
values, problems were encountered. While UCIContainer.set() accomodated
for uci list values using UCIContainer.listOptions,
UCIContainer.getScriptCommands() did not refer to
UCIContainer.listOptions and did not return the correct commands to set
uci list values. While investigating and correcting this problem,
various other corrections and simplifications were undertaken.

UCIContainer.set() is recoded
UCIContainer.listOptions is replaced with instanceof Array checks
UCIContainer.values is declared as an Object rather than an Array
UCIContainer.clone() corrected clone of Array values

The code has been made more simple and robust by removing the need to
maintain keys separately.

The use of keys[] has been replaced by tests on
values.hasOwnProperty(key) as recommended at:
http://stackoverflow.com/questions/11040472/check-if-object-property-
exists-using-a-variable#11040508

The code has been made more simple and robust by removing the need to
maintain keys separately.

The use of keys[] has been replaced by tests on
values.hasOwnProperty(key) as recommended at:
http://stackoverflow.com/questions/11040472/check-if-object-property-
exists-using-a-variable#11040508

device.sh is implemented to enable DeviceNames to be associated with one
or more MACs, and to enable DeviceNames to be assigned to Device Groups.

completed the initial i18n implementation in devices.sh

Gargoyle - Connections - Devices

rename SelectMAC
validate GroupName
implement Save Changes to uci

would have been nice if a extra } at the end of .js would generate a
warning!

dosfstools 3.0.27 not found in repositories

…into known-devices

Remove missed reference to keys

To resolve a mess

- various js tidy-up and bug fix
- correct device lable
- css layout for device & group table columns

The Edit Button is done a little differently than std Gargoyle. In
std Gargoyle the Edit Button pops up and populates a form for editing.
Here, the Edited Row is Removed and the fields in the ADD form are
populated with the existing info so that the user can adjust and re-add.
This approach seems intuitive for the User and makes the JS code simpler
and smaller. If editing a really large table then the User may be
confused when the row dissapears while not being able to see the Add Row
at the top?

The Gagoyle admin can use a Device Group to define a Quota by selecting
"Only the following Host(s) and providing an IP, or IP range, or a Device
Group. The Group can be selected or entered manually and it is validated
an saved thru the existing processes. The Device Group MACs are included
in the validation to avoid quota overlaps involving MACs.

To integrate the MACs validation, the groupsValid parameter was added to
the function addAddressStringToTable() and this cascaded small
adjustments to other JavaScript files which called this function.

Move uci configuration from known to dhcp

Each Device Group is reflected by an ipset of the same name. The ipset
is utilised in iptables to implement quota policy for a Device Group. IP
addresses are added and deleted from ipsets when a new dhcp lease is
assigned by setting dhcp.dnsmasq.dhcp_script

The dnsmasq dhcp-script is not available thru OpenWRT uci but it is
possible to suppliment the uci settings with /etc/dnsmasq.conf
https://wiki.openwrt.org/doc/uci/dhcp?&#using_plain_dnsmasqconf

- Reset all tables & selects after Save
- Add new Devices & Groups to Select Options while editing

Only first Quota assigned to a Device Group was being translated into
iptable rules. Fixed

…into known-devices

Gargoyle Firewall Access Restrictions & Whitelist can now accept Device
Groups

A number of functions were broken out from restore_quotas.c into a new
file uci-util.c to make them available to make_iptable_rules.c. This
also required a change to the Makefile and uci_util.h

The uci_context was introduced as a parameter to a number of functions
in make_iptable_rules.c to ensure only a single call to
uci_alloc_context().

function resetGroupsOptions() was moved from quotas.js to common.js to
make it readily available across Gargoyle GUI.

Duplicate (or improved) versions of these functions exist in common.js

Gargoyle QoS Classification rules can now accept Device Groups

…nto known-devices

…nto known-devices

…into known-devices

…nto known-devices

The Known Devices fieldset can associate a host name with a MAC address
and optionally assign a static IP address

The Known Devices table is populated with entries from uci and from
/etc/ethers & /etc/hosts. When the user Saves Changes then all devices
are saved into uci and /etc/ethers & /etc/hosts are recreated without
redundant entries.

An OpenWRT patch is backported to
"Allow UCI dhcp classifier to accept a list of MAC"
https://patchwork.ozlabs.org/patch/569678/

Recording each Device Group additionally as a uci dhcp mac classifier
enables the utilization of the dnsmasq --dhcp-option and makes 3
functions in common.js redundant.
https://wiki.openwrt.org/doc/uci/dhcp#classifying_clients_and_assigning_individual_options
http://www.thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html

Potential Wake On Lan hosts are now drawn from the uci system first
before drawing from arp, dhcp.leases and ethers

…nto known-devices

resolved conflicts:
	package/gargoyle/files/www/js/dhcp.js

Thank you lyrz

The restiction on the Device and Group names are different (based on uci
and ipset respectively) and a little confusing so it is important to
guide the user.

thank you ericwong

…nto known-devices

Resolved Conflicts:
	package/plugin-gargoyle-i18n-English-EN/files/www/i18n/English-
EN/strings.js

…nto known-devices

Resolved Conflicts:
	package/gargoyle/files/www/dhcp.sh
	package/gargoyle/files/www/js/common.js
	package/gargoyle/files/www/js/dhcp.js
	package/gargoyle/files/www/js/qos.js
	package/gargoyle/files/www/js/quotas.js
	package/gargoyle/files/www/quotas.sh

Corrected and strengthened saveChanges() to handle whitespace properly
and reject unknown host names

…nto known-devices