Catchup #3
Merged
Catchup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rubicon: adding pubcid support * adding to orderedParams * removed eids filter so all eids will be supported * fix eids test * fixed eids assertions Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com>
* basic implementation complete * add unit tests * remove redundant field tags[].video.frameworks
* submitting userId module for neustar's fabrick - https://www.home.neustar/fabrick * fixing 'gulp test' errors * fixing another test issue (related to ie) * removing another (last) repeat * - expose full user id config (including storage) to user id modules (#5803 - removing TODO from test * - updates to test Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar>
* adding options to renderAd method * adding replaceClickThrough method to utils * implemented replaceClickThrough method in render ad to enable ssps adding url param clickthrough for publisher side counting * update to cover some validation and unit tests as requested by harpere * adding unit test for clickthrough implementation;
Co-authored-by: Hugo Duthil <h.duthil@criteo.com>
* Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format * ad iframe and publisher domain paramters to bid requests * add publisher domain info in ad request * add a check in unit tests for publisherDomain * encode uri components Co-authored-by: Guillaume <guiandouard@gmail.com>
* add idx user id * Update modules/idxIdSystem.js to match new SubmoduleConfig param Co-authored-by: Scott <smenzer@gmail.com> Co-authored-by: Scott <smenzer@gmail.com>
* Change ironsource to be lower case all over code * Add test mode to the IronSource bidder
* add vuukle adapter * add readme * doc: add email
* Handling video outstream in smartadserver adapter. * Fixing the outstream example with the queue handler. Co-authored-by: tadam <tadam@smartadserver.com>
* add stroeerCoreBidAdapter * test correction * refactroring * add gvl id to spec Co-authored-by: Jakub Dlouhý <jakub.dlouhy@ibillboard.com> Co-authored-by: karel koule <koulekarel@gmail.com> Co-authored-by: Lukáš Havrlant <lukas.havrlant@gmail.com>
…rce bid adapter (#5834) * Added the ability to send multiple bids in one ad request for mediaforce bid adapter * Fixes after review for mediaforce bid adapter
* Added global function for refreshing user id's * Refactored submodule initialization to allow for refresh * Added submodule initialization when refreshing user id's * Refactored refresh parameter to be optional Refactored refresh user id's parameter to be optional where an empty list will result in all modules being refreshed. * Added unit tests for refresh user id's * Added single module refresh test * Test callback in refreshUserIds test * Remove zeotapIdPlus expiration on cookie in test because it caused it to intermittently fail Co-authored-by: chammon <chammon@rubiconproject.com>
* Added Hybrid.ai adapter * Is used 'find' from 'core-js/library/fn/array/find' instead Array.find * Fixed missing file extensions for imports * Typo fixed * Fixed missing file extensions for imports * Added support In-Image format * Added more test * Fixed errors of lint * Deleted debug line Co-authored-by: s.shevtsov <s.shevtsov@targetix.net>
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * not passing GDPR data in analytics * adding support for OpenWrap regex support * added unit test cases
* Added Trureach Prebid Adapter * cleaned up truereach bidder adapter for release * truereach bidder adapter md file for release * [truereach] bidder adapter and md files update. bidderUrl no more configurable. * [Prebid] supporting nurl * [Prebid] changes required due to code style * [Prebid] prebid unit test * [Prebid] added advertiserDomains in response object * [Prebid] Secure Bidder Url. * Added usersync support * changes in bidder url Co-authored-by: Nitin Kumar <nitin.kumar@momagic.com> Co-authored-by: arnav <arnav.mishra@momagic.com> Co-authored-by: arnav <arnav.mishra@momgaic.com>
Co-authored-by: Karim El Shabrawy <k.elshabrawy@criteo.com>
* Rubicon Adapter: Add multiple sizes to sizeMap * Add new size 500x1000 (ID: 548) in Rubicon Adapter Co-authored-by: Bret Gorsline <bgorsline@rubiconproject.com>
* Adding RTD, UserId. General modernization. * Update PR_REVIEW.md Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: Scott Menzer <scott@id5.io>
…y time, and cut down analytics requests to 1/10 (#5839) * ATS-analytics - add retry logic to not fire request for envelope every time, and cut down analytics requests to 1/10 * ATS-analytics - fix test naming
Co-authored-by: Hugo Duthil <h.duthil@criteo.com>
* add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * updated size validate Co-authored-by: cmertv-sishigami <s.ishigami@cmertv.com>
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * not passing GDPR data in analytics * adding support for OpenWrap regex support * added unit test cases * passing device platform in logger call; test cases added
* oolo analytics adapter added * update md * fix startsWith undefined * adjust tests * update tests - replace .find with .filter * update .md description
* Added voxBidAdapter.js to get a bid from partners.hybrid.ai * Added placements ids for testing Co-authored-by: s-shevtsov <s.shevtsov@targetix.net>
* added Engageya bid adapter * moved test function from adapter to spec * remove function import * PAGE_URL should be String
* Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter
* chore: lint HTML example page * chore: add space to logging statement for clarity * chore: update package lock * feat: turn off fullscan by default * chore: format the HTML for readibility * chore: fix test * Revert "chore: update package lock" This reverts commit 4faf194.
* update release process for notes on release drafter checks * update section titles
* add sspbc adapter * tests for sspbc adapter * sspBC adapter v4.5: set correct creativeId, add adomain to bid.meta, set test mode in adexchange, read site SN from bid response * sspBC adapter v4.5: set meta.advertiserDomains, update test to expect bid.meta * sspBC Adapter: add ajax tests (test ad with & without gdpr) * sspBC Adapter: remove ajax tests * Update adapter to v4.6 Update adapter to v4.6 - add notification endpoint - send bidWon and onTimeout notifications - send CMP version to user sync endpoint * Remove console logs for notification events * Change payload data in onTimeout event * Update tests for sspBC adapter Update tests for sspBC adapter: - add onBidWon test - add onTimeout test - alter getUserSyncs test * Update sspBC adapter to v4.7; enable oneCodeId mode; change module name to ensure combatibility with prebid.org downloader * sspBc adapter: Bug fixes in v4.7 - change notification format, fix oneCode detection data, convert slot number to int Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
* updated object,str,num validations using pbjs utils * validation if statements for content object * validation if statements for content object * updated contetn object validations using utils * refractoring clean if statement * fixing typos * added todos * added category string & data object validations * fixed esling ENDPOINT issue * updated content obj unit tests * fixed cat & data validation * fixed producer as object * revert .includes() to .indexof() for IE * reduced content obj params accoriding to ad-server support * fixed typeOf typo * fixed episode to Number * gitignore * restore gitignore * removed unsupported params from md file * reverted package & pagkage-lock * fixed incorrect episdoe from str to num
* adds support for new field - irisid * remove package-lock.json * revert psckage-lock.json to source
* add alias "adblender", custom endpoint * remove houseofpubs * add config example * update email * adblender.md fix naming
* Submit Zeta Adapter to Prebid * comments addressed * demo changes * additional polishing * additional polishing * Update hello_world.html * remove extraneous changes to hello_world.html * no, really this time * additional polishing * add unit test * Update Zeta bid adapter to pass more data
* Refactored dealId code to modularize obtaining ids from the Impression node
* Added support for obtaining bannerId and campaignId
* Added logic to prioritize Impression nodes with a rootViewKey
* Added test cases to cover new logic for obtaining dealId, bannerId, and campaignId
* Change ironsource to be lower case all over code * Add test mode to the IronSource bidder * get dynamic ttl from the server response * Change page_url logic
* NT. Trying out how webpack plays with env vars * NT. Test run before merge * NT. POC kinda ok for me now * NT. Updated the lc version to released one. * NT. Reverting test data. Ready for PR * NT. Fixing linting. * NT. Fixing the email hash scenario.
* Eplanning: new optional parameter is added * Eplanning: new prioritization metric for adunit sizes * Eplanning: desktop prioritization test for adunit sizes
* support TCFv2.0 * support coppa * support Publisher Domain * support meta.mediaType and meta.advertiserDomains * test parameters for validating bids Co-authored-by: root <root@ubuntu.members.linode.com> Co-authored-by: Ryan Chou <ryanchou0210@gmail.com> Co-authored-by: jack.hsieh <moonnight8520@gmail.com>
* pass GDPR consent data in dfpVideoUrl and dfpAdpodVideoUrl * Send gdpr param as a number Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
* TE Medya Prebid Adapter Hello @aleksatr , We have completed the prebid adapter development for our TE Medya advertisement panel. We ran the tests and checked that it works. I request your review. Best. * Create temedyaBidAdapter_spec.js * Update temedyaBidAdapter_spec.js * Update temedyaBidAdapter_spec.js * Update temedyaBidAdapter_spec.js
…ability with our api (#6169)
Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space
hannapanova190119
pushed a commit
that referenced
this pull request
Mar 16, 2021
… userId (prebid#6286) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added more userID partner support for IX adapter - NetID, Neustar, Zeotap (#1) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * added tests * added tests for new userinfo modules * missed a few checks * Dna 5040 ix userid support (#2) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added tests * added tests for new userinfo modules * missed a few checks Co-authored-by: Ran Li <ran.li@indexexchange.com> * added few missing checks in IX adapter * Use userIdAsEids instead of userId (#3) * use eids, revert package-lock * test update Co-authored-by: Ran Li <ran.li@indexexchange.com> Co-authored-by: amykwyang <amyyang90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information