Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _hulls property to allow a bmodel to set for which hulls it should have clipnodes #442

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Add _hulls property to allow a bmodel to set for which hulls it should have clipnodes #442

merged 2 commits into from
Dec 9, 2024

Conversation

L-P
Copy link
Contributor

@L-P L-P commented Nov 24, 2024

Fixes #418.

@L-P L-P force-pushed the feature/_illusionary branch from 0c6de7d to ac802a5 Compare November 26, 2024 17:03
@L-P L-P changed the title Add _illusionary to prevent clipnodes generation Add _hulls property to allow a bmodel to set for which hulls it should have clipnodes Nov 26, 2024
@L-P
Copy link
Contributor Author

L-P commented Nov 26, 2024

Went for a more generic solution than the original _illusionary.
Hulls can be set using a Flags property, one bit per hull. Default is 0, enables all hulls.

@L-P
Add _hulls bmodel property
04e4095 
Whitelist hulls for which to generate clipnodes.
@L-P L-P force-pushed the feature/_illusionary branch from ac802a5 to 04e4095 Compare November 29, 2024 22:25
@ericwa
Copy link
Owner

ericwa commented Dec 9, 2024

Thanks, looks good. I fixed "_hulls" "6" (i.e. generate hull 1 and 2 only) - it was letting me walk through (Quakespasm) until I adjusted it to generate the placeholder empty hull 0.

@ericwa ericwa merged commit d0788ac into ericwa:brushbsp Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] _illusionary on any entity to disable collision (like ZHLT's zhlt_noclip)
2 participants
@L-P @ericwa