Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git_tag in Erigon release on docker hub is incorrect #12661

Closed
yperbasis opened this issue Nov 7, 2024 · 1 comment
Closed

git_tag in Erigon release on docker hub is incorrect #12661

yperbasis opened this issue Nov 7, 2024 · 1 comment
Assignees
@lystopad
Labels
devops imp1 High importance
Milestone
2.60.11-fixes

Comments

@yperbasis
Copy link
Member

See #12525 (comment) <- the commit is right, but the tag is wrong

It's important to solve it since otherwise it's very confusing. If it's not feasible to solve the issue, it's better to remove git_tag altogether to avoid confusion.
@yperbasis yperbasis added devops imp1 High importance labels Nov 7, 2024
@yperbasis yperbasis changed the title git_tag in Erigon release is incorrect git_tag in Erigon release on docker hub is incorrect Nov 7, 2024
@yperbasis yperbasis added this to the 2.60.11-fixes milestone Nov 7, 2024
@lystopad lystopad mentioned this issue Nov 14, 2024
Merged
VBulikov pushed a commit that referenced this issue Nov 14, 2024
@lystopad
Create git tag before release build, small cosmetic changes. (#12721)
9d2d6a8 
See #12661 for more details.
Changes:
- workflow will create git tag referencing to the last commit id in
"checkout_ref" (branch name as for now)
- in case of not successful build -- second job will start and will
remove git tag.
- workflow will now contain useful name which reflects released version,
branch used to build artifacts and person who run workflow.
- latest docker base images debian:12.8-slim
@lystopad
Copy link
Member

Done in PR #12721

lystopad added a commit that referenced this issue Nov 20, 2024
@lystopad
Create git tag before release build, small cosmetic changes. (#12721)
e789eb2 
See #12661 for more details.
Changes:
- workflow will create git tag referencing to the last commit id in
"checkout_ref" (branch name as for now)
- in case of not successful build -- second job will start and will
remove git tag.
- workflow will now contain useful name which reflects released version,
branch used to build artifacts and person who run workflow.
- latest docker base images debian:12.8-slim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lystopad lystopad

Labels
devops imp1 High importance
Projects
None yet
Milestone
2.60.11-fixes
Development

No branches or pull requests
2 participants
@lystopad @yperbasis