Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txpool.BestPool: race #13477

Closed
AskAlexSharov opened this issue Jan 17, 2025 · 0 comments
Closed

txpool.BestPool: race #13477

AskAlexSharov opened this issue Jan 17, 2025 · 0 comments
Assignees
Labels
imp1 High importance

Comments

@AskAlexSharov
Copy link
Collaborator

==================
WARNING: DATA RACE
Write at 0x00c012583a80 by goroutine 327:
  github.com/erigontech/erigon/txnprovider/txpool.(*BestQueue).Push()
      /home/ubuntu/erigon/txnprovider/txpool/queues.go:76 +0x12c
  container/heap.Push()
      /usr/local/go/src/container/heap/heap.go:52 +0x45
  github.com/erigontech/erigon/txnprovider/txpool.(*SubPool).Add()
      /home/ubuntu/erigon/txnprovider/txpool/sub_pool.go:113 +0x576
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).addLocked()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:1519 +0x16a4
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).addTxns()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:1308 +0x86d
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).processRemoteTxns()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:511 +0x7c7
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).Run()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:1887 +0x9b2
  github.com/erigontech/erigon/eth.(*Ethereum).Start.func3()
      /home/ubuntu/erigon/eth/backend.go:1594 +0x7a
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/ubuntu/go/pkg/mod/golang.org/x/sync@v0.10.0/errgroup/errgroup.go:78 +0x91

Previous read at 0x00c012583a80 by goroutine 329:
  github.com/erigontech/erigon/txnprovider/txpool.(*BestQueue).Len()
      /home/ubuntu/erigon/txnprovider/txpool/queues.go:59 +0x1a7
  github.com/erigontech/erigon/txnprovider/txpool.(*SubPool).Len()
      /home/ubuntu/erigon/txnprovider/txpool/sub_pool.go:105 +0x187
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).OnNewBlock.func1()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:313 +0x6f
  runtime.deferreturn()
      /usr/local/go/src/runtime/panic.go:605 +0x5d
  github.com/erigontech/erigon/txnprovider/txpool.(*Fetch).handleStateChangesRequest()
      /home/ubuntu/erigon/txnprovider/txpool/fetch.go:516 +0x47a
  github.com/erigontech/erigon/txnprovider/txpool.(*Fetch).handleStateChanges()
      /home/ubuntu/erigon/txnprovider/txpool/fetch.go:468 +0x2ad
  github.com/erigontech/erigon/txnprovider/txpool.(*Fetch).ConnectCore.func1()
      /home/ubuntu/erigon/txnprovider/txpool/fetch.go:124 +0xa4


@yperbasis yperbasis added the imp1 High importance label Jan 17, 2025
@AskAlexSharov AskAlexSharov self-assigned this Jan 17, 2025
AskAlexSharov added a commit that referenced this issue Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imp1 High importance
Projects
None yet
Development

No branches or pull requests

2 participants