Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect transaction debug output on BSC #5865

Closed
quickchase opened this issue Oct 25, 2022 · 3 comments · Fixed by #6274
Closed

Incorrect transaction debug output on BSC #5865

quickchase opened this issue Oct 25, 2022 · 3 comments · Fixed by #6274

Comments

@quickchase
Copy link
Contributor

Using the latest version on BSC: v2.28.1 (and older versions)

The following trace is incorrect:

{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "debug_traceTransaction",
  "params": [
    "0xebf83628ba893d35b496121fb8201666b8e09f3cbadf0e269162baa72efe3b8b",
    { "tracer": "callTracer" }
  ]
}

It returns:

"error":"execution reverted"

However, this transaction is successful (the receipt says it was successful too):
https://www.bscscan.com/tx/0xebf83628ba893d35b496121fb8201666b8e09f3cbadf0e269162baa72efe3b8b

Same output if you do debug_traceBlockByNumber

May be related to #5308
@MysticRyuujin
Copy link
Contributor

MysticRyuujin commented Oct 25, 2022 •
edited
Loading

As was pointed out on Discord. The address in question that submit this transaction was part of the NanoBlackList - which means that the likely cause of this issue is that the state transition logic is returning an error instead of allowing the transaction to complete? But I'm not smart enough to dig through all that fork logic 🥲

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 5, 2022
@MysticRyuujin
Copy link
Contributor

It's still a problem

@github-actions github-actions bot removed the Stale label Dec 6, 2022
@AlexeyAkhunov AlexeyAkhunov mentioned this issue Dec 10, 2022
Merged
AlexeyAkhunov added a commit that referenced this issue Dec 10, 2022
@AlexeyAkhunov
Workaround for the code history of BSC system contracts (#6274)
0a31f5a 
Works around a flaw in the upgrade logic of the system contracts. Since
they are updated directly, without first being self-destructed and then
re-created, the usual incarnation logic does not get activated, and all
historical records of the code of these contracts are retrieved as the
most recent version. This problem will not exist in erigon3, but until
then, a workaround will be used to access code of such contracts through
a special structure, `SystemContractCodeLookup`

Fixes #5865

Co-authored-by: Alexey Sharp <alexeysharp@Alexeys-iMac.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround for the code history of BSC system contracts erigontech/erigon
2 participants
@MysticRyuujin @quickchase