Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support safe/finalized block strings in eth_getLogs #8454

Closed
BrendanChou opened this issue Oct 12, 2023 · 2 comments
Closed

Support safe/finalized block strings in eth_getLogs #8454

BrendanChou opened this issue Oct 12, 2023 · 2 comments

Comments

@BrendanChou
Copy link

BrendanChou commented Oct 12, 2023 •
edited
Loading

Rationale

This issue was closed after only supporting a subset of the block string values. Support all block string values in eth_getLogs.

Implementation

One-liner: Change this -2 to -4. (Should also change the name of the variable).
@BrendanChou BrendanChou changed the title Support safe/finalized/latest blocks in eth_getLogs Support safe/finalized/latest block strings in eth_getLogs Oct 12, 2023
@BrendanChou BrendanChou changed the title Support safe/finalized/latest block strings in eth_getLogs Support safe/finalized block strings in eth_getLogs Oct 12, 2023
@Termina1
Copy link

Termina1 commented Nov 9, 2023

Please, fix it

@adytzu2007 adytzu2007 mentioned this issue Mar 12, 2024
Merged
@yperbasis
Copy link
Member

Fixed by PR #9686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Termina1 @BrendanChou @yperbasis