-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow safe/finalized for eth_getLogs #9686
Allow safe/finalized for eth_getLogs #9686
Conversation
This fixes issue #8454 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think better change from -2 to -4 (or -5) , instead of removing validation at all
Hey @AskAlexSharov, I checked and the unmarshal code doesn't allow explicit negative numbers so the only way to get a negative number in this code would be due to a symbolic name such as "safe". |
@adytzu2007 what geth does in this case? we may do something compatible if it's good |
AFAICT, geth doesn't run any other validation on the block number in GetLogs once it unmarshals it from JSON. It also doesn't support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove now unused "math/big" from the import
01c38e9
to
3d134d1
Compare
No description provided.