Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine API: NewPayload fails with a "context canceled" error in Current/GetHeader (#9786) #10180

Merged
merged 1 commit into from
May 3, 2024

Commits on May 2, 2024

  1. Engine API: NewPayload fails with a "context canceled" error in Curre…

    …nt/GetHeader (#9786) (#9894)
    
    * improved logging
    * check ctx in ServeHTTP: The context might be cancelled if the client's
    connection was closed while waiting for ServeHTTP.
    * If execution API returns ExecutionStatus_Busy, limit retry attempts to
    10 seconds. This timeout must be lower than a typical client timeout (30
    sec), in order to give the client feedback about the server status.
    * If execution API returns ExecutionStatus_Busy, increase retry delay
    from 10 ms to 100 ms to avoid stalling ourselves with multiple busy
    loops. IMO this delay should be higher (e.g. 1 sec). Ideally we
    shouldn't do polling at all, but doing a blocking ctx call requires
    rearchitecting the ExecutionStatus_Busy logic.
    
    see #9786
    battlmonstr committed May 2, 2024
    Configuration menu
    Copy the full SHA
    24645c6 View commit details
    Browse the repository at this point in the history