fix regression in json encoding of stack values in traces due to change of uint256 String() method #11061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeepdino008
approved these changes
Jul 8, 2024
lupin012
pushed a commit
that referenced
this pull request
Aug 30, 2024
…ge of uint256 String() method (#11061) Regression caused by this change in uint256 library: holiman/uint256@f24ed59 It was causing trace json to encode stack values as quoted (string) decimal values rather than a hex encoded value.
AskAlexSharov
pushed a commit
that referenced
this pull request
Aug 31, 2024
…chan… (#11810) cherry-pick from PR #11061 from main (the regression is present also in release 2.60) Regression caused by this change in uint256 library: holiman/uint256@f24ed59 It was causing trace json to encode stack values as quoted (string) decimal values rather than a hex encoded value. Co-authored-by: bgelb <ben.gelb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression caused by this change in uint256 library:
holiman/uint256@f24ed59
It was causing trace json to encode stack values as quoted (string) decimal values rather than a hex encoded value.