polygon/sync: fix block too soon error #11499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-accum-producer-priorities
…-accum-producer-priorities
…-accum-producer-priorities
…-accum-producer-priorities
…-accum-producer-priorities
taratorio
added a commit
that referenced
this pull request
Aug 6, 2024
part of #11032 adds 2 new types and corresponding logic: - `SpanBlockProducerSelection` - explanation can be found in the doc string - `spanBlockProducersTracker` - in high-level: it is an internal component of the heimdall service which registers for span updates. It accumulates the block producer priorities from span 0 to latest and persists them in the heimdall db (or in the stage loop db if run as part of the stage loop integration mode). Provides a `Producers(blockNum)` API which returns correct accumulated producer priorities. In subsequent PRs, I will start using the new `Producers(blockNum)` API in the Astrid chain tip mode (PR #11499) and also add unit tests (PR #11426) for the entire heimdall service.
…dgerwatch/erigon into astrid-fix-block-too-soon-err
…block-too-soon-err
…block-too-soon-err
antonis19
approved these changes
Aug 6, 2024
somnathb1
pushed a commit
that referenced
this pull request
Aug 16, 2024
part of #11032 adds 2 new types and corresponding logic: - `SpanBlockProducerSelection` - explanation can be found in the doc string - `spanBlockProducersTracker` - in high-level: it is an internal component of the heimdall service which registers for span updates. It accumulates the block producer priorities from span 0 to latest and persists them in the heimdall db (or in the stage loop db if run as part of the stage loop integration mode). Provides a `Producers(blockNum)` API which returns correct accumulated producer priorities. In subsequent PRs, I will start using the new `Producers(blockNum)` API in the Astrid chain tip mode (PR #11499) and also add unit tests (PR #11426) for the entire heimdall service.
somnathb1
pushed a commit
that referenced
this pull request
Aug 16, 2024
part of #11032 Fixes "block too soon error" which was due to incorrectly calculated block producer priorities. ``` DBUG[08-06|13:31:23.898] [sync] onNewBlockEvent: couldn't connect a header to the local chain tip, ignoring err="canonicalChainBuilder.Connect: invalid header error Block 10391894 was created too soon. Signer turn-ness number is 2\n" ``` Removes `SpansCache` in favour of `heimdallService.Producers` which returns correct producer priorities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #11032
Fixes "block too soon error" which was due to incorrectly calculated block producer priorities.
Removes
SpansCachein favour ofheimdallService.Producerswhich returns correct producer priorities.