Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DomainRange in KvServer #11853

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Implement DomainRange in KvServer #11853

merged 2 commits into from
Sep 4, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Sep 3, 2024

It is necessary when using temporal KV remotely.

Additional changes:

  • remove what I think is an oversight in IndexRange, where req.PageSize was checked and cut to PageSizeLimit, but then not used (PageSizeLimit itself was used instead)
  • remove useless limit-- in HistoryRange

@AskAlexSharov AskAlexSharov merged commit ce2ecf8 into main Sep 4, 2024
10 checks passed
@AskAlexSharov AskAlexSharov deleted the kvserver_domain_range branch September 4, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants