polygon/sync: fix parent td missing when forking at the tip #11867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh0lt
approved these changes
Sep 4, 2024
antonis19
reviewed
Sep 4, 2024
polygon/sync/sync.go
Outdated
| newHeaders[i] = block.HeaderNoCopy() | ||
| headerChain := make([]*types.Header, len(blockChain)) | ||
| for i, block := range blockChain { | ||
| block.Hash() |
There was a problem hiding this comment.
Why is block.Hash() called here?
There was a problem hiding this comment.
good catch, I accidentally left it over after debugging
antonis19
reviewed
Sep 4, 2024
polygon/sync/sync.go
Outdated
| if err := s.store.InsertBlocks(ctx, newBlocks); err != nil { | ||
| return err | ||
| } | ||
| // len(blockChain) is always <= len(newConnectedHeaders) |
There was a problem hiding this comment.
Isn't it the other way around?
There was a problem hiding this comment.
yes, good catch, corrected
antonis19
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11818
issue was:
InsertBlocksfor the blocks we've just connected and also tocommitExecution(callUpdateForkChoice)fix is:
canonicalChainBuilder.Connectto return the newly connected headers to the tree