Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonrpc/trace): add createType for parity traces #12557

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 31, 2024

similiar to ethereum/go-ethereum#30539 add createType for the create traces.

@mriccobene
Copy link
Member

Please, to fix RPC Integration tests on this PR try changing the workflow at this line using --branch feature/add_createtype_for_parity_traces

@jsvisa
Copy link
Contributor Author

jsvisa commented Nov 4, 2024

@mriccobene sorry for the inconvenience, for the compatibly reason, we may name it from createType to creationMethod, so I'll change erigon's code after geth's got merged(ref ethereum/go-ethereum#30539 (comment)).

@mriccobene
Copy link
Member

@jsvisa can you contribute to my branch by changing the method name accordingly, from createType to creationMethod or as you decided, in the failing tests? you can look at my commit and do the same.

@jsvisa
Copy link
Contributor Author

jsvisa commented Nov 4, 2024

@jsvisa can you contribute to my branch by changing the method name accordingly, from createType to creationMethod or as you decided, in the failing tests? you can look at my commit and do the same.

yeah, sounds good to me. May I ask, if this means I can file a PR and set the destination branch as https://github.com/erigontech/rpc-tests/tree/feature/add_createtype_for_parity_traces, or based on the add_createtype_for_parity_traces branch, and send another PR to in https://github.com/erigontech/rpc-tests

@mriccobene
Copy link
Member

May I ask, if this means I can file a PR and set the destination branch as [...], or based on the add_createtype_for_parity_traces branch, and send another PR to in https://github.com/erigontech/rpc-tests

I think it's easier to create a new PR on a fresh branch; my branch can only help you as a guide. Note that in the test run log you can see the failed tests and in the test run artifacts there are the files with the expected and actual values ​​- these files can serve you instead of my branch to fix the failing tests

Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants