Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache tx granularity #13134

Merged
merged 4 commits into from
Dec 18, 2024
Merged

cache tx granularity #13134

merged 4 commits into from
Dec 18, 2024

Conversation

JkLondon
Copy link
Member

closes #13088
Not really sure about 2 caches conception but like it

@JkLondon JkLondon self-assigned this Dec 16, 2024
func (g *Generator) GetReceipt(ctx context.Context, cfg *chain.Config, tx kv.TemporalTx, block *types.Block, index int, txNum uint64) (*types.Receipt, error) {
if receipt, ok := g.receiptCache.Get(txNum); ok {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

txNum is not reorg-resistant

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AskAlexSharov AskAlexSharov merged commit f56bf08 into main Dec 18, 2024
13 checks passed
@AskAlexSharov AskAlexSharov deleted the cache-tx-gran branch December 18, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receipts generator: add new cache with per-txn granularity
2 participants