-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/vm: BLS gas changes for pectra-devnet-5 per EIP-2537 #13346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
changed the title
BLS gas changes for pectra-devnet-5 per EIP-2537
[Do-Not_Merge] BLS gas changes for pectra-devnet-5 per EIP-2537
Jan 8, 2025
somnathb1
changed the title
[Do-Not_Merge] BLS gas changes for pectra-devnet-5 per EIP-2537
BLS gas changes for pectra-devnet-5 per EIP-2537
Jan 9, 2025
This is 6/6 in the Chain |
somnathb1
changed the title
BLS gas changes for pectra-devnet-5 per EIP-2537
core/vm: BLS gas changes for pectra-devnet-5 per EIP-2537
Jan 14, 2025
Also ethereum/EIPs#8945 was implemented |
yperbasis
reviewed
Jan 15, 2025
@@ -439,7 +407,7 @@ func BenchmarkPrecompiledP256Verify(b *testing.B) { | |||
} | |||
|
|||
func TestPrecompiledP256Verify(t *testing.T) { | |||
t.Parallel() | |||
// t.Parallel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was it commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will uncomment. Needed it for testing.
yperbasis
reviewed
Jan 15, 2025
yperbasis
approved these changes
Jan 15, 2025
Merged
somnathb1
added a commit
that referenced
this pull request
Jan 16, 2025
Refer to the following: ethereum/EIPs#9116 ethereum/EIPs#9098 ethereum/EIPs#9097 ethereum/EIPs#8945 Issue board: #12401 --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
somnathb1
added a commit
that referenced
this pull request
Jan 17, 2025
…13469) Refer to the following: ethereum/EIPs#9116 ethereum/EIPs#9098 ethereum/EIPs#9097 ethereum/EIPs#8945 Issue board: #12401 Cherry pick #13346 --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the following:
ethereum/EIPs#9116
ethereum/EIPs#9098
ethereum/EIPs#9097
ethereum/EIPs#8945
Issue board: #12401