Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized eth_createAccessList #3453

Merged
merged 7 commits into from
Feb 14, 2022
Merged

Optimized eth_createAccessList #3453

merged 7 commits into from
Feb 14, 2022

Conversation

yperbasis
Copy link
Member

No description provided.

@yperbasis yperbasis linked an issue Feb 9, 2022 that may be closed by this pull request
@yperbasis yperbasis changed the title [WIP] Optimized eth_createAccessList Optimized eth_createAccessList Feb 14, 2022
@yperbasis yperbasis marked this pull request as ready for review February 14, 2022 15:59
@yperbasis yperbasis added the beta label Feb 14, 2022
@AlexeyAkhunov AlexeyAkhunov merged commit 64f4de5 into devel Feb 14, 2022
@AlexeyAkhunov AlexeyAkhunov deleted the optimize_access_list branch February 14, 2022 18:39
AlexeyAkhunov pushed a commit that referenced this pull request Feb 16, 2022
* Make blockNrOrHash optional in CreateAccessList (in line with geth)

* OptimizedAccessList

* cosmetics

* optimizeGas param instead of separate method

* Inline toAddress
AlexeyAkhunov added a commit that referenced this pull request Feb 16, 2022
* Make blockNrOrHash optional in CreateAccessList (in line with geth)

* OptimizedAccessList

* cosmetics

* optimizeGas param instead of separate method

* Inline toAddress

Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
yperbasis pushed a commit that referenced this pull request Oct 1, 2023
This builds upon #3453 and #3524, which previously implemented gas
optimizations for the access lists generated by Erigon's implementation
of the `eth_createAccessList` RPC call.

Erigon currently optimizes inclusion of the recipient address based on
how many storage keys are accessed, but does not perform the same
optimization for sender address and precompiled contract addresses.
These changes make the same optimization available for all of these
cases.

Additionally, this handles the cases of block producer address and
created smart contract addresses. If these cases were omitted on purpose
since they heavily rely on state, it may still make sense to offer them
to users but disable them by default.
yperbasis added a commit that referenced this pull request Oct 1, 2023
Enable gas optimizations of PRs #3453 & #8261 unless the `optimizeGas`
argument is explicitly set to `false`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize eth_createAccessList
2 participants