Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing trace #5320

Closed
wants to merge 6 commits into from
Closed

Fixing trace #5320

wants to merge 6 commits into from

Conversation

enriavil1
Copy link
Contributor

@enriavil1 enriavil1 commented Sep 8, 2022 •
edited
Loading

  • Checking if trace is Parlia for gasBailOut instead of hardcoded false
  • Adding value into balanceCheck even though the transaction is not an EIP-1559

@enriavil1 enriavil1 marked this pull request as ready for review September 9, 2022 09:52
mandrigin
mandrigin requested changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@mandrigin mandrigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to change state_transition if the block was synced successfully

core/state_transition.go Outdated Show resolved Hide resolved
@enriavil1 enriavil1 requested a review from mandrigin September 14, 2022 11:03
@alexlee85
Copy link

any progress of this PR? I've being stucked at block 15539509 on mainnet. 😭

@enriavil1 enriavil1 closed this Sep 16, 2022
@AskAlexSharov AskAlexSharov deleted the fixing-trace branch November 30, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@revitteth revitteth Awaiting requested review from revitteth

@AlexeyAkhunov AlexeyAkhunov Awaiting requested review from AlexeyAkhunov

@mandrigin mandrigin Awaiting requested review from mandrigin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enriavil1 @alexlee85 @mandrigin @AskAlexSharov