Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bor file structure updated #6167

Merged
merged 26 commits into from
Jan 31, 2023
Merged

Bor file structure updated #6167

merged 26 commits into from
Jan 31, 2023

Conversation

anshalshukla
Copy link
Collaborator

@anshalshukla
Copy link
Collaborator Author

The work is still in progress

@AskAlexSharov AskAlexSharov changed the title bor file structure updated [wip] bor file structure updated Dec 3, 2022
@0xKrishna
Copy link
Collaborator

I will review it soon.

@0xKrishna 0xKrishna changed the title [wip] bor file structure updated Bor file structure updated [ In Review ] Jan 3, 2023
@enriavil1
Copy link
Contributor

With so many changes it might be a good idea to start adding more bor specific tests. Because of the size of the chain it is difficult to test it, by running the chain

@0xKrishna
Copy link
Collaborator

@enriavil1 I have done the testing with the team, I think this PR is good to merge.
Once @anshalshukla resolves the merge conflict, Then after a final review we can merge this.
For reference we can always compare this with original bor repo.

We have to get this PR merged soon because we have some features in original bor repo which are pending on erigon side and they are dependent on this file structure change. So first we do this file structure change and then only we can start implementing those feature which are important from stability point of view.

Copy link
Contributor

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Great work @anshalshukla 🚀

Have added few minor comments. Also, as discussed, let's undo remove all changes in metrics package. We'll add them in a different PR as discussed.

consensus/bor/heimdall/span/spanner.go Outdated Show resolved Hide resolved
consensus/bor/heimdall/span/spanner.go Outdated Show resolved Hide resolved
consensus/bor/heimdall/span/spanner.go Outdated Show resolved Hide resolved
consensus/bor/heimdall/span/spanner.go Outdated Show resolved Hide resolved
consensus/bor/snapshot_test.go Outdated Show resolved Hide resolved
eth/ethconsensusconfig/config.go Outdated Show resolved Hide resolved
consensus/bor/heimdall/metrics.go Outdated Show resolved Hide resolved
consensus/bor/heimdall/metrics.go Show resolved Hide resolved
consensus/bor/bor.go Outdated Show resolved Hide resolved
consensus/bor/bor.go Show resolved Hide resolved
consensus/bor/bor.go Outdated Show resolved Hide resolved
consensus/bor/bor.go Show resolved Hide resolved
@0xKrishna 0xKrishna changed the title Bor file structure updated [ In Review ] Bor file structure updated Jan 29, 2023
Copy link
Contributor

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKrishna 0xKrishna merged commit a4f8175 into erigontech:devel Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants