-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bor file structure updated #6167
Bor file structure updated #6167
Conversation
The work is still in progress |
I will review it soon. |
With so many changes it might be a good idea to start adding more bor specific tests. Because of the size of the chain it is difficult to test it, by running the chain |
@enriavil1 I have done the testing with the team, I think this PR is good to merge. We have to get this PR merged soon because we have some features in original bor repo which are pending on erigon side and they are dependent on this file structure change. So first we do this file structure change and then only we can start implementing those feature which are important from stability point of view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Great work @anshalshukla 🚀
Have added few minor comments. Also, as discussed, let's undo remove all changes in metrics
package. We'll add them in a different PR as discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
POS-859