feat(trace): use specific error string #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revitteth
force-pushed
the
feat/clearer-trace-error
branch
from
93bfedd to
a457c70
Compare
hexoscott
approved these changes
Jan 25, 2023
revitteth
force-pushed
the
feat/clearer-trace-error
branch
4 times, most recently
from
a4bf96e to
a1af8c7
Compare
revitteth
force-pushed
the
feat/clearer-trace-error
branch
from
a1af8c7 to
ef2f8c2
Compare
|
Tests to follow in subsequent PR. This now returns the trace with the correct error. A few notes:
|
mandrigin
reviewed
Jan 26, 2023
mandrigin
approved these changes
Jan 26, 2023
revitteth
force-pushed
the
feat/clearer-trace-error
branch
from
a46b8b4 to
c94033b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.36.0 we correctly trace this transaction, however due to a code ordering issue in previous releases, there was an 'out of gas' response, because we fell through to the code here where ErrContractAddressCollision will be returned as such. This change isn't the fix, but ensures the actual error is returned.