Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic on some AuRa transactions in the past #6760

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Don't panic on some AuRa transactions in the past #6760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c851b2
better way of checking for system txs in AuRa
mandrigin Feb 1, 2023
461e7c9
add log message
mandrigin Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions consensus/aura/aura.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,10 +1251,16 @@ func (c *AuRa) IsServiceTransaction(sender libcommon.Address, syscall consensus.
}
res, err := certifierAbi().Unpack("certified", out)
if err != nil {
panic(err)
mandrigin marked this conversation as resolved.
Show resolved Hide resolved
log.Warn("error while detecting service tx on AuRa", "err", err)
return false
}
if len(res) == 0 {
return false
}
if certified, ok := res[0].(bool); ok {
return certified
}
certified := res[0].(bool)
return certified
return false
}

// Close implements consensus.Engine. It's a noop for clique as there are no background threads.
Expand Down