Fix getBlockTransactionCount returning null #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fafrd
changed the title
AskAlexSharov
approved these changes
Feb 7, 2023
finiteops
pushed a commit
to bitfinity-network/erigon
that referenced
this pull request
Apr 10, 2023
So... for blocks that don't exist, the eth_getBlockTransactionCount RPCs should return `null`. Erigon does this correctly right now and this is covered by the unit test in [rpcdaemon/commands/corner_cases_support_test.go](https://github.com/ledgerwatch/erigon/blob/devel/cmd/rpcdaemon/commands/corner_cases_support_test.go). But, for blocks that don't have any transactions, like [703696](https://etherscan.io/block/703696), the RPC also returns `null`. I've changed this to correctly return `0` and have added 2 new tests to handle it. (I had to add another block to the test chain in rpcdaemon/rpcdaemontest/test_util.go and had to fix a few other tests that broke as a result.) Resolves erigontech#6775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... for blocks that don't exist, the eth_getBlockTransactionCount RPCs should return
null. Erigon does this correctly right now and this is covered by the unit test in rpcdaemon/commands/corner_cases_support_test.go.But, for blocks that don't have any transactions, like 703696, the RPC also returns
null.I've changed this to correctly return
0and have added 2 new tests to handle it. (I had to add another block to the test chain in rpcdaemon/rpcdaemontest/test_util.go and had to fix a few other tests that broke as a result.)Resolves #6775