devnet: fix node startup on macOS #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
battlmonstr
commented
Oct 24, 2023
•
battlmonstr
commented
- call getEnode before NodeStarted to make sure it is ready for RPC calls
- fix connection error detection on macOS
- use a non-default p2p port to avoid conflicts
- disable bor milestones on local heimdall
- generate node keys for static peers config
* call getEnode before NodeStarted to make sure it is ready for RPC calls * fix connection error detection on macOS * use a non-default p2p port to avoid conflicts
battlmonstr
force-pushed
the
pr/devnet_fix
branch
2 times, most recently
from
fc650bc to
f396cf6
Compare
battlmonstr
force-pushed
the
pr/devnet_fix
branch
from
f396cf6 to
ec35bad
Compare
battlmonstr
force-pushed
the
pr/devnet_fix
branch
from
ec35bad to
4bd59f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.