polygon/sync: canonical chain builder #9117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/cc_builder
branch
from
fe91291
to
6d8d76b
Compare
taratorio
reviewed
Jan 3, 2024
taratorio
reviewed
Jan 3, 2024
taratorio
reviewed
Jan 3, 2024
taratorio
reviewed
Jan 3, 2024
taratorio
reviewed
Jan 3, 2024
| return errors.New("canonicalChainBuilderImpl.Connect: invalid header.Time") | ||
| } | ||
|
|
||
| if err := bor.ValidateHeaderExtraField(header.Extra); err != nil { |
There was a problem hiding this comment.
Have a look at checkHeaderExtraData - when the header is the last of a sprint we do more validations - check the span selected proposers match the validator bytes in the header extra data.
Maybe add a todo if not adding as part of this PR?
On another note it may be a good idea if we write down a list of all validations we should be doing and double check the code later on that we have them all?
There was a problem hiding this comment.
👍 Yes, I planned to do more validations in the next PRs and wanted to discuss some of them.
taratorio
reviewed
Jan 3, 2024
taratorio
reviewed
Jan 3, 2024
battlmonstr
force-pushed
the
pr/cc_builder
branch
from
993a264
to
42f188e
Compare
mh0lt
approved these changes
Jan 3, 2024
battlmonstr
force-pushed
the
pr/cc_builder
branch
from
16a41b7
to
9f290f1
Compare
AskAlexSharov
pushed a commit
that referenced
this pull request
Jan 5, 2024
A crash on startup happens on --chain=mumbai , because I've confused chainConfig.Bor (from type chain.Config) and config.Bor (from type ethconfig.Config) in the setup code. ethconfig.Config.Bor property contained bogus values, and was used only to check its type in CreateConsensusEngine(). Its value was never read (before PR #9117). This change removes the property to avoid confusion and fix the crash. Devnet network.BorStateSyncDelay was implemented using ethconfig.Config.Bor, but it wasn't taking any effect. It should be fixed separately in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.