Caplin: Fixed EL<->CL communication for Deneb #9257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
approved these changes
Jan 22, 2024
yperbasis
added a commit
that referenced
this pull request
Jan 22, 2024
golang slice can be `nil`. There's no reason to pass it by pointer. This is a fix to PR #9257. It fixes the following error in Hive test "Withdrawals Fork on Block 1 (Paris)": ``` << (0953747c) {"jsonrpc":"2.0","id":5,"error":{"code":-32000,"message":"ethereumExecutionModule.InsertBlocks: blob gas used is nil"}} CLMocker: Could not ExecutePayloadV1: ethereumExecutionModule.InsertBlocks: blob gas used is nil CLMocker: BroadcastNewPayload Error (0953747c): ethereumExecutionModule.InsertBlocks: blob gas used is nil ```
|
Needs more context, as to why the move. This breaks existing Engine-API expected error response in case of invalid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the blob hashes verification to execution driven service