Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add totalBlobPoolLimit flag #9406

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Add totalBlobPoolLimit flag #9406

merged 2 commits into from
Feb 9, 2024

Conversation

somnathb1
Copy link
Contributor

Summary
Adds a new flag/parameter totalBlobPoolLimit to the txpool.
Any time the number of blobs (total of all blobs in all type-3 txs) exceeds this number, the pool won't accept any more blob txs.
This is a very straightforward way to prevent blob spamming. It also gives a node operator the freedom to stay away from too many blobs in their own pool.

More background: Blob txs take a huge toll on the txpool and the rest of the system because of their size and cryptography involved.

@yperbasis yperbasis added the dencun The Deneb/Cancun protocol upgrade label Feb 8, 2024
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestBlobSlots fails with

    pool_test.go:1129: Total blobs in pool 20
    pool_test.go:1134: Reasons [%!v(PANIC=String method: discard reason: 31)]
panic: discard reason: 31 [recovered]
	panic: discard reason: 31

@somnathb1 somnathb1 merged commit 9820577 into devel Feb 9, 2024
7 checks passed
@somnathb1 somnathb1 deleted the som/blob_limit branch February 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dencun The Deneb/Cancun protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants