Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updateForkChoice: support --sync.loop.block.limit (#9315)" #9833

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Mar 28, 2024

Revert PR #9315 since it apparently causes MDBX bloat and performance regression. The regression was introduced in v2.58.0.

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@yperbasis yperbasis marked this pull request as ready for review March 28, 2024 09:29
@yperbasis yperbasis merged commit a013ec2 into release/2.59 Mar 28, 2024
12 of 13 checks passed
@yperbasis yperbasis deleted the revert_9315 branch March 28, 2024 11:25
Kakkarrot pushed a commit to covalenthq/erigon that referenced this pull request Apr 17, 2024
…#9315)" (erigontech#9833)

Revert PR erigontech#9315 since it apparently causes MDBX bloat and performance
regression. The regression was introduced in
[v2.58.0](https://github.com/ledgerwatch/erigon/releases/tag/v2.58.0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants